Fix MQTT message error handling and improve connection responses#1784
Merged
Technoboy- merged 6 commits intomasterfrom Jul 29, 2025
Merged
Fix MQTT message error handling and improve connection responses#1784Technoboy- merged 6 commits intomasterfrom
Technoboy- merged 6 commits intomasterfrom
Conversation
|
@coderzc:Thanks for your contribution. For this PR, do we need to update docs? |
coderzc
force-pushed
the
fix_connect_refused
branch
from
46176fa to
5598343
Compare
coderzc
force-pushed
the
fix_connect_refused
branch
from
04bd631 to
5983d79
Compare
Technoboy-
reviewed
Jul 29, 2025
...mmon/src/main/java/io/streamnative/pulsar/handlers/mqtt/common/MQTTCommonInboundHandler.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jul 29, 2025
coderzc
added a commit
that referenced
this pull request
Jul 29, 2025
coderzc
added a commit
that referenced
this pull request
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when there is an exception in checking the connect message, we directly close the channel. However, the client might keep retrying indefinitely. It's best for us to return a connection error to the client.
Modifications
For CONNECT message errors, send a CONNACK error response then close channel.
For other message errors, send a DISCONNECT error response if supported then close channel.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)